MTV-1433 Rearranging prerequisites in the MTV user guide #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHoch
changed the title
RichardHoch
force-pushed
the
prereqs_by_provider
branch
from
cb6ca0b to
f899fce
Compare
RichardHoch
changed the title
RichardHoch
force-pushed
the
prereqs_by_provider
branch
from
1cc1857 to
9160c8a
Compare
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
nunzy1
reviewed
Dec 9, 2024
RichardHoch
commented
Dec 11, 2024
RichardHoch
commented
Dec 11, 2024
RichardHoch
commented
Dec 11, 2024
RichardHoch
commented
Dec 11, 2024
|
@nunzy1 I made many of the changes you suggested and did a little other rewriting. Please review this PR again. Thanks. |
RichardHoch
force-pushed
the
prereqs_by_provider
branch
from
637ed1a to
d01e70d
Compare
fabiand
requested changes
Jan 10, 2025
| @@ -6,16 +6,17 @@ | |||
| [id="creating-vddk-image_{context}"] | |||
| = Creating a VDDK image | |||
|
|
|||
|
|
|||
| It is strongly recommended that {project-first} should be used with the VMware Virtual Disk Development Kit (VDDK) SDK when transferring virtual disks from VMware vSphere. | |||
There was a problem hiding this comment.
Can we take this line, omve it into the note, and replacing the current text (Creating a VDDK …)
There was a problem hiding this comment.
@fabiand Instead, I suggest removing the note and leaving "It is strongly recommended..." as is. Please take a look and see what you think.
|
|
||
| [TIP] | ||
| ==== | ||
| It is strongly recommended to disable hibernation because {project-first} does not support migrating hibernated VMs. |
There was a problem hiding this comment.
If we know for sure that it fails, then we should reword to
Hibernation must be disabled because {project-first} does not support migrating hibernated VMs.
There was a problem hiding this comment.
@fabiand @mnecas Please note that information about ports is still missing: https://issues.redhat.com/browse/MTV-1714
RichardHoch
force-pushed
the
prereqs_by_provider
branch
from
8784b97 to
6b58484
Compare
RichardHoch
force-pushed
the
prereqs_by_provider
branch
2 times, most recently
from
1f61667 to
975217b
Compare
Signed-off-by: RichardHoch <[email protected]>
RichardHoch
force-pushed
the
prereqs_by_provider
branch
from
975217b to
8326dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTV 2.8
Partially resolves https://issues.redhat.com/browse/MTV-1433 by grouping prerequisites by vendor (VMware, RHV, etc.) where possible.
Previews:
Note -- Some port information is missing. This is indicated by "TBD".